What conflict made Roosevelt a national hero

Future president Theodore Roosevelt became famous during the Spanish-American war when he led his unit of Calvary, called the rough riders, and captured San Juan Hill.

Which Roosevelt, there were two. Teddy Roosevelt was a famous hero for the Spanish-American War, in which he took part in the battle in San Juan Hill. Franklin Roosevelt had polio, so he could not fight, but he led the Allies to victory in WW2