What kind of ion do metal and nommetal make?

Typically speaking metals usually make positively charged ions which are called cations. Metals want to lose their electrons to become more stable.

Non-metals typically want to gain electrons to become more stable. These ions become negatively charged and are called anions.

Common mistake: Sometimes people think that if you are adding an electron the ion becomes positive BUT you have to remember that electrons are negatively charged. If you add electrons the ion becomes negatively charged and vise versa.